Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: menu widget bugs #37

Merged
merged 3 commits into from
Jul 16, 2021
Merged

fix: menu widget bugs #37

merged 3 commits into from
Jul 16, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Jul 16, 2021

Overview

What I've done

Kapture 2021-07-16 at 15 57 06

Fixes:

  • Icons don't be displayed
  • Camera doesn't fly once flight button is clicked
  • Warning from Markdown component
  • "Undefined" page will open when url property is empty and button os clicked
  • When menu text is CJK only, it breaks the line

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@rot1024 rot1024 changed the title fix: menu widget fix: menu widget bugs Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #37 (40c7adc) into main (16f265a) will decrease coverage by 0.09%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   52.24%   52.15%   -0.10%     
==========================================
  Files          45       45              
  Lines         645      650       +5     
  Branches      125      125              
==========================================
+ Hits          337      339       +2     
- Misses        233      237       +4     
+ Partials       75       74       -1     
Impacted Files Coverage Δ
src/components/atoms/Icon/index.tsx 56.25% <37.50%> (-10.42%) ⬇️
src/components/atoms/Markdown/index.tsx 56.52% <50.00%> (+1.97%) ⬆️

Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rot1024 rot1024 merged commit 5d5483c into main Jul 16, 2021
@rot1024 rot1024 deleted the fix-menu branch July 16, 2021 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants