Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

perf: improve unnecessary loading the globe image #378

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Dec 15, 2022

Overview

What I've done

I removed imageryProvider={false} props for Viewer component.
This props removes the loaded globe image. The props is used in here.
Therefore this cause unnecessary loading globe image when the Viewer component is re-rendered.

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this Dec 15, 2022
@netlify
Copy link

netlify bot commented Dec 15, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 0e25af8
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/639a984d082c48000976807a
😎 Deploy Preview https://deploy-preview-378--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #378 (0e25af8) into main (61e67ef) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   24.53%   24.53%           
=======================================
  Files         597      597           
  Lines       62873    62871    -2     
  Branches     1243     1243           
=======================================
  Hits        15428    15428           
+ Misses      47399    47397    -2     
  Partials       46       46           
Impacted Files Coverage Δ
...nents/molecules/Visualizer/Engine/Cesium/index.tsx 0.00% <ø> (ø)
src/core/engines/Cesium/index.tsx 0.00% <ø> (ø)

@rot1024 rot1024 changed the title fix: improve unnecessary loading the globe image perf: improve unnecessary loading the globe image Dec 15, 2022
@keiya01 keiya01 merged commit 4abbbac into main Dec 15, 2022
@keiya01 keiya01 deleted the improve-unmount branch December 15, 2022 04:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants