Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: disable default cesium mouse event #42

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Jul 16, 2021

Overview

What I've done

To prevent camera from being pinned to a marker by double-clicking, disable default cesium mouse events.

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #42 (3ddf0ea) into main (01aadfc) will decrease coverage by 0.44%.
The diff coverage is 36.84%.

❗ Current head 3ddf0ea differs from pull request most recent head fea6725. Consider uploading reports for the commit fea6725 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   52.59%   52.15%   -0.45%     
==========================================
  Files          44       45       +1     
  Lines         635      650      +15     
  Branches      122      125       +3     
==========================================
+ Hits          334      339       +5     
- Misses        226      237      +11     
+ Partials       75       74       -1     
Impacted Files Coverage Δ
...n/PluginAccordion/PluginAccordionItem/itemBody.tsx 100.00% <ø> (ø)
...PluginAccordion/PluginAccordionItem/itemHeader.tsx 72.22% <ø> (ø)
.../Settings/Project/Plugin/PluginAccordion/index.tsx 100.00% <ø> (ø)
...es/Settings/Project/Plugin/PluginSection/index.tsx 83.33% <ø> (ø)
src/gql/graphql-client-api.tsx 52.63% <ø> (-0.03%) ⬇️
src/gql/provider.tsx 5.88% <0.00%> (-0.79%) ⬇️
src/theme/darkTheme.ts 100.00% <ø> (ø)
src/theme/theme.ts 100.00% <ø> (ø)
src/theme/z-index.ts 100.00% <ø> (ø)
src/sentry.ts 33.33% <33.33%> (ø)
... and 5 more

@HideBa HideBa merged commit 129ae36 into main Jul 16, 2021
@HideBa HideBa deleted the disable-default-mouse-event branch July 16, 2021 08:31
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
* fix: skip nil geomatries

* test: add test case for nil geometry
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants