Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: graphiql page #70

Merged
merged 3 commits into from
Sep 2, 2021
Merged

feat: graphiql page #70

merged 3 commits into from
Sep 2, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Aug 31, 2021

Overview

reearth/reearth-visualizer#89

Add GraphiQL page to enable to debug GraphQL

  • URL: /graphql
  • An access token will be automatically injected to headers
  • Not available on production build

Why GraphiQL, not GraphQL Playground?

  • graphql-playground-react has a dependency to Redux
  • Error were occurred when I tried graphql-playground-react and it did not work
  • GitHub adopts GraphiQL on the GraphQL playground page for GitHub GraphQL API

Screenshot

image

@netlify
Copy link

netlify bot commented Aug 31, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: d725ed3

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/613045a048951f0008c5b044

😎 Browse the preview: https://deploy-preview-70--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #70 (d725ed3) into main (ea980cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   58.10%   58.10%           
=======================================
  Files          40       40           
  Lines         685      685           
  Branches       96       96           
=======================================
  Hits          398      398           
  Misses        245      245           
  Partials       42       42           

HideBa
HideBa previously approved these changes Aug 31, 2021
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Plz, write docs if it's needed.

KaWaite
KaWaite previously approved these changes Sep 2, 2021
Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed grammar for the message if not logged in. Other than that change LGTM!

Co-authored-by: KaWaite <34051327+KaWaite@users.noreply.github.com>
@rot1024 rot1024 dismissed stale reviews from KaWaite and HideBa via d725ed3 September 2, 2021 03:31
@rot1024 rot1024 merged commit aa5d108 into main Sep 2, 2021
@rot1024 rot1024 deleted the feat/graphiql branch September 2, 2021 03:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants