-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 37f1e70 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/6170e089b25f4d0008362102 😎 Browse the preview: https://deploy-preview-99--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 53.53% 53.53%
=======================================
Files 48 48
Lines 891 891
Branches 119 119
=======================================
Hits 477 477
Misses 364 364
Partials 50 50
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a comment which is about the entire review. Thereby I won't review detail until we make a decision. Plz, take a look at my comment.
This PR should be reviewed by me at least once. Please don't merge this PR until then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* rename widget system and plugin system * refactor tests
Overview
Up until now, widgets could only have one instance. Also, we were unable to remove a widget (and its data) completely, only disable. This brings both.
What I've done
The dropdown showing installed widgets will grey out widgets that are single-use and already have a single instance.
Trying to delete a selected widget will show a confirmation modal before deleting.
What I haven't done
I haven't fixed an issue with the LayerTreeView components where the whole tree will be re-rendered on ANY changes made within (this includes local state). This affects the toggle's transition so it doesn't smoothly move, as well as the widget dropdown is contained within the left panel (where it should come out slightly over Cesium. Also affects the left panel's help balloons) and it will be slightly clipped the first time opening the dropdown.
How I tested
Screenshot
Which point I want you to review particularly
Memo