Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --lifecycleRule option with improved validation #182
add --lifecycleRule option with improved validation #182
Changes from all commits
25bd832
ee7d302
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full
means it's something missing from the original, while this is here only to provide a higher order validation of some inputs. How aboutvalidation
ortypechecks
, or even justchecks
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, but it is missing, and we only allow installing without since we acknowledge some people may run into issues with the additional dependencies.
Then there is also this - Assume we add pycurl support, then if you are a user which want the best experience possible, and you don't care if there are binary dependencies or whatnot (and why would you as the user?), do you really want to do
pip install
b2[pycurl,validation]` ?It seems like a common practice to group them (https://github.com/encode/uvicorn/blob/master/pyproject.toml#L36-L44 , https://github.com/pandas-dev/pandas/blob/main/pyproject.toml#L81 ) .
We could do add extra group for just validation boost, for these users that do really care about nitpicking their dependencies, but I'm not sure how big of group will that be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, but in these cases
all
means that literally all dependencies are added, and each of them have a hefty list of optionals that can be added as well. So it should also includedoc
andlicense
, andcurl
and everything else in thisfull
, shouldn't it? Currently it's just addingpydantic
, which is used only for validation, isn't it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against
full
, orall
. I'm just saying that thisfull
is not reallyfull
.