forked from Backblaze/b2-sdk-python
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Large File Upload Continification Logic #286
Merged
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3d5777b - Browse repository at this point
Copy the full SHA 3d5777bView commit details -
Refactor unfinished file search logic and improve documentation
This commit refactors the logic used to search for unfinished file uploads in the bucket, primarily focusing on the `_find_unfinished_file_by_plan_id`, `_match_unfinished_file_if_possible`, and `_find_matching_unfinished_file` functions. Key changes include: - Extracting shared logic into `_find_matching_unfinished_file`. This increased code reuse, and improved code maintenance and readability. - Refactoring `_find_unfinished_file_by_plan_id` and `_match_unfinished_file_if_possible` to use the shared logic, enhancing their readability and reliability. - Enhancing function documentation. Docstrings were updated to be more informative and adhere to a standard template. - Adding a note indicating 'listFiles' access is required for the operations.
Configuration menu - View commit details
-
Copy full SHA for 7d64e31 - Browse repository at this point
Copy the full SHA 7d64e31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2863d88 - Browse repository at this point
Copy the full SHA 2863d88View commit details -
Configuration menu - View commit details
-
Copy full SHA for a51417a - Browse repository at this point
Copy the full SHA a51417aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a78ba72 - Browse repository at this point
Copy the full SHA a78ba72View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1ab961 - Browse repository at this point
Copy the full SHA c1ab961View commit details -
Configuration menu - View commit details
-
Copy full SHA for d077efd - Browse repository at this point
Copy the full SHA d077efdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 370043e - Browse repository at this point
Copy the full SHA 370043eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a56bd07 - Browse repository at this point
Copy the full SHA a56bd07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3965e2c - Browse repository at this point
Copy the full SHA 3965e2cView commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c9752b0 - Browse repository at this point
Copy the full SHA c9752b0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.