Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Large File Upload Continification Logic #286

Merged
merged 11 commits into from
Jul 3, 2023

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    3d5777b View commit details
    Browse the repository at this point in the history
  2. Refactor unfinished file search logic and improve documentation

    This commit refactors the logic used to search for unfinished file
    uploads in the bucket, primarily focusing on the
    `_find_unfinished_file_by_plan_id`, `_match_unfinished_file_if_possible`,
    and `_find_matching_unfinished_file` functions.
    
    Key changes include:
    
    - Extracting shared logic into `_find_matching_unfinished_file`. This
      increased code reuse, and improved code maintenance and readability.
    
    - Refactoring `_find_unfinished_file_by_plan_id` and
      `_match_unfinished_file_if_possible` to use the shared logic, enhancing
      their readability and reliability.
    
    - Enhancing function documentation. Docstrings were updated to be more
      informative and adhere to a standard template.
    
    - Adding a note indicating 'listFiles' access is required for the
      operations.
    przadka committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7d64e31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2863d88 View commit details
    Browse the repository at this point in the history
  4. Fixed typo in a comment.

    przadka committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a51417a View commit details
    Browse the repository at this point in the history
  5. Fixed formatting.

    przadka committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a78ba72 View commit details
    Browse the repository at this point in the history
  6. Changelog update

    przadka committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c1ab961 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d077efd View commit details
    Browse the repository at this point in the history
  8. PR feedback implemented

    przadka committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    370043e View commit details
    Browse the repository at this point in the history
  9. Always log rejections

    przadka committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a56bd07 View commit details
    Browse the repository at this point in the history
  10. Replace assert with exception

    przadka committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3965e2c View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    c9752b0 View commit details
    Browse the repository at this point in the history