Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize state part 2 #134

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

rokostik
Copy link
Contributor

This PR finishes serializing state for all supported objects.

@refaktor
Copy link
Owner

Great! I was waiting for this, to move some other things forward. This will be great building block! Have you tested it with Rye shell session in practice?

@refaktor refaktor closed this Feb 18, 2024
@refaktor refaktor reopened this Feb 18, 2024
@refaktor refaktor merged commit f050e2b into refaktor:main Feb 18, 2024
13 checks passed
@rokostik
Copy link
Contributor Author

@refaktor yes, tested everything I could in interactive shell sessions. I also want to write tests for this but haven't gotten around to doing it yet.

@refaktor
Copy link
Owner

Great! :)
Did you load it by opening the shell and doing do load %shell_... file or somehow else so I won't be mentally reinventing the wheel :)

@rokostik
Copy link
Contributor Author

I did the simplest thing possible... savign the state and inputting it by hand from the saved file 😅 I looked at the shell code and I don't think it's currently possible to load the state from a file and continue from there right?

@refaktor
Copy link
Owner

refaktor commented Feb 19, 2024

:)
you can do do load %file in shell or if shell dump/script would have enter-console "" at the end it would enter it. I will probably add some flag to rye executable where it loads a file and enters console after it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants