Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(supabase): nested embedded resources sorting #6025

Conversation

youssefsiam38
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

When sorters value is

[
    {
        "field": "posts.categories.tags",
        "order": "asc"
    }
]

The resulted url query param

posts.order=categories.tags.asc

What is the new behavior?

When sorters value is

[
    {
        "field": "posts.categories.tags",
        "order": "asc"
    }
]

The resulted url query param

posts.categories.order=tags.asc

Notes for reviewers

Postgrest documentation

@youssefsiam38 youssefsiam38 requested a review from a team as a code owner June 8, 2024 05:23
Copy link

changeset-bot bot commented Jun 8, 2024

🦋 Changeset detected

Latest commit: df5600f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/supabase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BatuhanW BatuhanW changed the title Fix Supabase nested embedded resources sorting fix(supabase): nested embedded resources sorting Jun 10, 2024
@BatuhanW BatuhanW changed the base branch from master to releases/july June 20, 2024 08:54
@BatuhanW BatuhanW added this to the July Release milestone Jun 20, 2024
Copy link
Member

@BatuhanW BatuhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@BatuhanW BatuhanW merged commit f4e61b0 into refinedev:releases/july Jun 26, 2024
12 checks passed
@BatuhanW BatuhanW mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants