-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 6 support. #80
Conversation
So we can ignore the majority of the job failures in the build since Stacktrace:
Right now travis is configured to use the following non-supported rubies 2.4.4, 2.3.7, 2.2.10. |
The other failures are from being unable to connect to a database.
and
So the build is failing due to configuration issues. |
- Remove non-supported ruby versions from TravisCI. - Loosen gem restrictions on mobility so we can update to a version that supports Rails 6.
I tested building this gem locally and it looks like it resolved the bundler conflicts we were having in the main Once this is merged and built as a gem, RefineryCMS will be very close to supporting Rails 6! |
- 2.3.7 | ||
- 2.2.10 | ||
sudo: false | ||
- 2.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 2.6.1 | |
- 2.6.4 |
- 2.2.10 | ||
sudo: false | ||
- 2.6.1 | ||
- 2.5.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 2.5.3 | |
- 2.5.6 |
sudo: false | ||
- 2.6.1 | ||
- 2.5.3 | ||
- 2.4.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 2.4.5 | |
- 2.4.7 |
You're right, it's redundant. We might as well specify |
This is to support the work in refinerycms-core, see this pull request for the details.
As of right now, if you download that branch and try using it in a fresh Rails 6 application, you'll see the following bundler error:
Take note of the last 3 lines. Hopefully, with this commit we can start using RefineryCMS on Rails 6 once that other PR is finished & merged in!
Sidenote: looking at the third to last line
refinerycms-i18n (>= 5.0.0, ~> 5.0)
. Won't the second rule overtake the first one? Since that's in the refinery core gem spec, I'm not sure. I know the bundler rules better than the gemspec rules (not sure if they match exactly either).