Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-browser screenshots refactor #254

Merged
merged 27 commits into from
Jun 10, 2023
Merged

Cross-browser screenshots refactor #254

merged 27 commits into from
Jun 10, 2023

Conversation

nwittwer
Copy link
Collaborator

@nwittwer nwittwer commented Jun 9, 2023 •
edited
Loading

  • Removed need to use complicated custom separate browser installer code; instead use Playwright's CLI directly in the Electron process: e.g. playwright install webkit
  • Added basic tests to ensure packaged app has playwright-core module, and doesn't have .local-browsers at runtime. Browsers will be installed on first run.
  • Added RuntimeConfig
  • Added test to ensure final build directory is <500mb
  • Fixed incorrect scroll instead of wheel event in inject.js (WebPage)
  • Fixed blocking bug in inject script when no title is found
  • Improved UI for cross-browser screenshots

@nwittwer
(WIP) Added scripts to auto-install hermetic Playwright browsers and …
5d17780 
…detect already-installed ones
@nwittwer
Merge branch 'dev' into @reflex/browser-installer
da88d49
@nwittwer
Added consts to ./config to help synchronize app config settings, re-…
e992aee 
…enabled ASAR packing
@nwittwer
Made Electron test fixture more OS/platform robust
3d47b76
@nwittwer
Added test.skip() for placeholder test to verify that the built app h…
0617884 
…as the correct Playwright env variable configured
@nwittwer
Moved Playwright worker to main process
3211349
@nwittwer
Added API for triggering Playwright
2418834
@nwittwer
Added main process script to manage Playwright installs using `npx …
3c49a00 
…playwright install`
@nwittwer
Add playwright-core to excluded dependencies for Nuxt Vite
c874fb8
@nwittwer
Removed vite-plugin-comlink from nuxt.config
bdb2163
@nwittwer
Added missing app dependencies, added Playwright ENV to package scrip…
ce7bbd9 
…ts, removed vite-plugin-comlink
@nwittwer
(WIP) Updated front-end to call main back-end for cross-browser scr…
bd8d74b 
…eenshots
@nwittwer
Improved UI for displaying CB screenshots
164daeb
@nwittwer
Fixed incorrect 'scroll' event instead of 'wheel' in inject.js (WebPage)
4f1634f
@nwittwer
Improved screenshot functions and types
66e2c4c
@nwittwer
Added 'ignoreHTTPSErrors' to Playwright config
cf31461
@nwittwer
(WIP) Use Playwright CLI via node_modules path instead of npx
e13efba
@nwittwer
Catch errors when getting page data in inject script instead of stopping
3cd7743
@nwittwer
Added .ts support to builder.config
d3e899a
@nwittwer
Add build:debug for hard-coded Mac packaged app debugging
b7a152c
@nwittwer
(WIP) Refactored browser manager to use fork instead of spawn
41cd28c
@nwittwer
Extended Playwright fixture for Electron to expose additional useful …
3672a60 
…app paths
@nwittwer
Added test to check if Playwright is packaged in built app
db75740
@nwittwer
Moved site-tree test to separate file
8031668
@nwittwer
Added VSCode debugger for built app
f327105
@nwittwer
Fixed RuntimeConfig
91b9a96
@nwittwer
Added Electron test to ensure Reflex directory is less than 500MB
b326793
@nwittwer nwittwer merged commit f676b87 into dev Jun 10, 2023
@nwittwer nwittwer deleted the @reflex/browser-installer branch June 10, 2023 10:39
@nwittwer nwittwer linked an issue Jun 10, 2023 that may be closed by this pull request
Fix Playwright screenshots & Worker #249
Closed
@nwittwer nwittwer mentioned this pull request Jun 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Playwright screenshots & Worker
1 participant
@nwittwer