Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTM-838][GTM-841]Add template name and fix broken template links #1089

Merged
merged 13 commits into from
Nov 26, 2024

Conversation

ElijahAhianyo
Copy link
Collaborator

No description provided.

@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review November 14, 2024 16:31
@ElijahAhianyo
Copy link
Collaborator Author

ElijahAhianyo commented Nov 14, 2024

Screenshot 2024-11-14 at 4 40 35 PM

Initial proposal on what the template cards look like. Thoughts on this? @Alek99 @picklelo

@ElijahAhianyo
Copy link
Collaborator Author

Screenshot 2024-11-14 at 4 40 35 PM Initial proposal on what the template cards look like. Thoughts on this? @Alek99 @picklelo

I kept it this way because the template names are kebab cased on reflex init and I thought it was intuitive to have titles as Title-cases with whitespaces instead of hyphens(or underscores). We could argue that names could simply be formatted for the titles, but that means the name displayed on the title will differ from that when you click the copy button which could be confusing, so instead, having the template name explicitly stated should clear this up. My only issue here is the use of Template name again before specifying the actual name. Not a designer, so would need your feedback on that as well

@ElijahAhianyo
Copy link
Collaborator Author

Screenshot 2024-11-14 at 6 34 50 PM

Another proposal inspired by Carlos

@ElijahAhianyo
Copy link
Collaborator Author

This PR now depends on reflex-dev/templates#44 and reflex-dev/templates#45

@ElijahAhianyo
Copy link
Collaborator Author

Screenshot 2024-11-15 at 7 38 54 PM

@ElijahAhianyo
Copy link
Collaborator Author

Screenshot 2024-11-15 at 7 38 54 PM

@picklelo @tgberkeley lmk what you think

@Alek99
Copy link
Member

Alek99 commented Nov 21, 2024

Lets change the init with template

Says in terminal

"""Go to the templates page (http://reflex.dev/templates/) and copy the command to init with a template

The command will be like the following 'reflex init --template template_name"
"""

Then cuts the command and does not take then to the template page, that way they can see the command

Now when they go to template

When clicking copy on the template page it should copy the whole command

reflex init --template ....

The user pastes this command into their terminal


The ui will look like this

Screenshot 2024-11-20 at 9 41 18 PM

@ElijahAhianyo
Copy link
Collaborator Author

Screenshot 2024-11-24 at 11 05 36 AM

@ElijahAhianyo ElijahAhianyo requested review from Alek99 and removed request for tgberkeley November 24, 2024 13:22
import `copy_script` from the shiki code block and reuse it
allow truncation ellipses and auto tooltip logic in browsers like safari and firefox
@Alek99 Alek99 merged commit be49517 into main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants