Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lucide icons as a candidate for core icon library #2444

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

Lendemor
Copy link
Collaborator

size, strokeWidth and color can be customized like in the following example:

import reflex as rx

rx.lucide.icon(tag="moon", size=24, strokeWidth="1"),
rx.lucide.icon(tag="moon", size=48, strokeWidth="2"),
rx.lucide.icon(tag="moon", size=24, strokeWidth="2", color="red"),
rx.lucide.icon(tag="moon", size=48, strokeWidth="2", color="blue"),
image

Copy link
Member

@Alek99 Alek99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from discord

he only comment I have with this is that if they are using the theme provider I would like this to default to using it so it can look good in a button like so https://www.radix-ui.com/themes/docs/components/button
We may need to make a method that can check if a theme is being used
We can also get rid of radix icons as we only need one icon lib

reflex/components/lucide/icon.py Show resolved Hide resolved
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@picklelo picklelo merged commit 11f6d7c into main Jan 29, 2024
45 checks passed
@picklelo picklelo deleted the lendemor/lucide_icons branch January 30, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants