Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: radix section default size #3406

Merged
merged 2 commits into from
May 31, 2024
Merged

refactor: radix section default size #3406

merged 2 commits into from
May 31, 2024

Conversation

Jishnu-Nandhiath
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

#3274

Changed the default size of rx.section to "2" from "3" as mentioned.

masenf
masenf requested changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run poetry run python scripts/make_pyi.py reflex/components/radix/themes/layout/section.py and commit the result.

@Jishnu-Nandhiath
Copy link
Contributor Author

@masenf Done!

picklelo
picklelo approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@picklelo picklelo merged commit 83d9988 into reflex-dev:main May 31, 2024
46 of 47 checks passed
@picklelo picklelo mentioned this pull request Jun 3, 2024
Closed
benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request Jun 3, 2024
@Jishnu-Nandhiath @benedikt-bartscher
refactor: radix section default size (reflex-dev#3406)
18e44bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf requested changes

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jishnu-Nandhiath @masenf @picklelo