-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF-3016]Allow special characters in upload ID #3449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahAhianyo
changed the title
[REF-3016]Disallow special characters in upload ID
[REF-3016]Allow special characters in upload ID
Jun 6, 2024
masenf
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we still have a problem when the id
contains the backtick character...
>>> import reflex.components.core.upload as upl
>>> print(str(upl.upload_file("foo`bar")))
{e => setFilesById(filesById => {
const updatedFilesById = Object.assign({}, filesById);
updatedFilesById[`foo`bar`] = e;
return updatedFilesById;
})
}
If we convert the id_
to a Var with _var_is_string=True, and then get the _var_name_unwrapped
, then it provides the outer backticks automatically and escapes the inner backtick(s)
>>> import reflex as rx
>>> rx.Var.create_safe("foo`bar", _var_is_string=True)._var_name_unwrapped
'`foo\\`bar`'
ElijahAhianyo
force-pushed
the
elijah/upload-id-validate
branch
from
June 11, 2024 10:10
73655ec
to
fb477f9
Compare
masenf
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow special characters as upload id for the following:
fixes #3444