swap all use of get_event_triggers to rx.EventHandler props #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Jun 10, 2024
| @@ -223,35 +276,6 @@ def _get_imports(self): | |||
| }, | |||
| ) | |||
|
|
|||
| def get_event_triggers(self) -> Dict[str, Callable]: | |||
There was a problem hiding this comment.
removing this has resulted in the addition of the base Component.get_event_triggers default triggers, is that appropriate for this component? or should we have a get_event_triggers here that returns an empty dict?
There was a problem hiding this comment.
Adding get_event_triggers that returns {} has caused events triggers to be completely removed from the docs on the data-editor page.
masenf
previously approved these changes
Jun 11, 2024
picklelo
previously approved these changes
Jun 12, 2024
I'm not sure yet, they are still used in the base Component I think. I'm hesitant to convert this one to rx.EventHandler right now because I'm not sure it won't have side effect. if we can I'll do it in a follow up PR. |
picklelo
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what the title says.