Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) recharts fixes batch #3 #3496

Merged
merged 9 commits into from
Jun 18, 2024
Merged

(WIP) recharts fixes batch #3 #3496

merged 9 commits into from
Jun 18, 2024

Conversation

HongyuHansonYao
Copy link
Contributor

@HongyuHansonYao HongyuHansonYao commented Jun 14, 2024 •
edited
Loading

  1. Removed fill and stroke prop from LabelList(Recharts) class - general.py
  2. Refactored eventHandler using Masen's new method for Legend(Recharts) class - general.py
  3. Removed x and y prop from Reference(Recharts) class, put them in ReferenceLine(Reference) class instead - cartesian.py.
  4. Updated type for x, y, stroke_width, added stroke prop to ReferenceLine(Reference) class - cartesian.py
  5. Added r, fill, stroke prop to ReferenceDot(Reference) class - cartesian.py

@HongyuHansonYao HongyuHansonYao merged commit eb397da into main Jun 18, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

@Alek99 Alek99 Awaiting requested review from Alek99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HongyuHansonYao @masenf