Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-3076] Do not purge .web/pages in dev mode #3592

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Jun 29, 2024

Avoid race condition in hot reload that occurs when pages are removed before they are recreated.

Fix #3416

Avoid race condition in hot reload that occurs when pages are removed before
they are recreated.

Fix #3416
Copy link

linear bot commented Jun 29, 2024

@benedikt-bartscher
Copy link
Contributor

@masenf shouldn't this be REF-3076 instead of REF-3067?

@masenf masenf changed the title [REF-3067] Do not purge .web/pages in dev mode [REF-3076] Do not purge .web/pages in dev mode Jul 1, 2024
Copy link

linear bot commented Jul 1, 2024

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@masenf masenf merged commit 9e1789a into main Jul 9, 2024
47 checks passed
@masenf masenf deleted the masenf/dynamic-route-hot-reload-404 branch July 9, 2024 03:17
Alek99 pushed a commit that referenced this pull request Jul 15, 2024
* [REF-3067] Do not purge .web/pages in dev mode

Avoid race condition in hot reload that occurs when pages are removed before
they are recreated.

Fix #3416

* use constants instead of hardcoded string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REF-3076] 404 with recomplilation when working on routes
3 participants