Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-3101] rx.list Dont set/hardcode list_style_position css prop #3695

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ElijahAhianyo
Copy link
Collaborator

@ElijahAhianyo ElijahAhianyo commented Jul 22, 2024

This should allow setting list_style_postion(which was previously hard-coded to outside) css prop to take effect:

import reflex as rx

def index():
   return rx.vstack(
       rx.list.unordered(
            rx.list.item("Example 1"),
            rx.list.item("Example 2"),
            rx.list.item("Example 3"),
            list_style_position="outside"
        ),
        rx.list.unordered(
            rx.list.item("Example 4"),
            rx.list.item("Example 5"),
            rx.list.item("Example 6"),
            list_style_position="inside",
        ),
)

app = rx.App()
app.add_page(index)

Also for some reason, the original issue(#2934) which prompted setting the list_style_position prop among others in the pr (#2936) renders fine without setting the prop

@ElijahAhianyo ElijahAhianyo changed the title rx.list Dont set/hardcode list_style_position css prop [REF-3101] rx.list Dont set/hardcode list_style_position css prop Jul 22, 2024
Copy link

linear bot commented Jul 22, 2024

@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review July 22, 2024 15:47
@picklelo picklelo merged commit decdc85 into main Jul 22, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants