Get default for backend var defined in mixin #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the backend var is defined in a mixin class, it won't appear in `cls.__dict__`, but the value is still retrievable via `getattr` on `cls`. Prefer to use the actual defined default before using `Var.get_default_value()`. If `Var.get_default_value()` fails, set the default to `None` such that the backend var still gets recognized as a backend var when it is used on `self`. ---- Update test_component_state to include backend vars Extra coverage for backend vars with and without defaults, defined in a ComponentState/mixin class.
picklelo
approved these changes
Oct 4, 2024
masenf
added a commit
that referenced
this pull request
Oct 7, 2024
* Get default for backend var defined in mixin If the backend var is defined in a mixin class, it won't appear in `cls.__dict__`, but the value is still retrievable via `getattr` on `cls`. Prefer to use the actual defined default before using `Var.get_default_value()`. If `Var.get_default_value()` fails, set the default to `None` such that the backend var still gets recognized as a backend var when it is used on `self`. ---- Update test_component_state to include backend vars Extra coverage for backend vars with and without defaults, defined in a ComponentState/mixin class. * fix integration test
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Get default for backend var defined in mixin If the backend var is defined in a mixin class, it won't appear in `cls.__dict__`, but the value is still retrievable via `getattr` on `cls`. Prefer to use the actual defined default before using `Var.get_default_value()`. If `Var.get_default_value()` fails, set the default to `None` such that the backend var still gets recognized as a backend var when it is used on `self`. ---- Update test_component_state to include backend vars Extra coverage for backend vars with and without defaults, defined in a ComponentState/mixin class. * fix integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the backend var is defined in a mixin class, it won't appear in
cls.__dict__, but the value is still retrievable viagetattroncls. Prefer to use the actual defined default before usingVar.get_default_value().If
Var.get_default_value()fails, set the default toNonesuch that the backend var still gets recognized as a backend var when it is used onself.Update test_component_state to include backend vars
Extra coverage for backend vars with and without defaults, defined in a ComponentState/mixin class.