Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use larger or equal for node version check #4189

Merged
merged 1 commit into from
Oct 16, 2024
Merged

use larger or equal for node version check #4189

merged 1 commit into from
Oct 16, 2024

Conversation

adhami3310
Copy link
Member

No description provided.

@adhami3310
Copy link
Member Author

on another note, the place that checks this just assumes it does >=, and prints a confusing error message like "node version X must be at least X"

masenf
masenf approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean up of the logic

@adhami3310 adhami3310 merged commit 35810fe into main Oct 16, 2024
31 checks passed
Kastier1 pushed a commit that referenced this pull request Oct 23, 2024
@adhami3310
use larger or equal for node version check (#4189)
0d16f22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @masenf