upgrade node to latest lts #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
approved these changes
Oct 18, 2024
|
i thought we were going to wait until tomorrow when node 22 becomes lts... |
|
yea that was not supposed to merge, it's not breaking anything, so we can wait till tomorrow to see if any new release happens and any changes need to happen |
|
Oh my bad / shall I revert this? |
no i think it's fine. @adhami3310 in the future, if we have PRs that are ready and approved but shouldn't be merged yet, lets keep them as draft |
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs 22 will reach LTS in a week from now, only merge after that happens and a new LTS release has happened (most likely 22.10.0)
https://endoflife.date/nodejs