Add on progress typing to react player #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is waiting on #4210 |
masenf
reviewed
Oct 22, 2024
it's technically rebased on main i just added some additional changes (because i'm silly) |
masenf
approved these changes
Oct 22, 2024
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
* add on progress typing to react player * fix pyi file * have the pyi here as well * more pyi changes * fix imports * run pyi * for some reason it want event on three lines no clue why * simplify case for when type is in the same module * run pyi * remove last missing type for datadisplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.