-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOS-93: add support for .env file #4219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so in this case, if the env_file
is specified, then it overrides values defined in the environment already? is there any "automatic" env file? or is it only loaded if the user explicitly sets one?
remove stray print, merge from main
, relock dependencies
There is no automatic env file. If they do no supply one we do nothing. If they do we use those values over what is in their env already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Could we make the |
Is there any reason in particular to make it optional?
We are looking into making this optional but was curious as to why you wanted this |
* HOS-93: add support for .env file * HOS-93: remove stray print * HOS-93: poetry lock * HOS-93: update comment --------- Co-authored-by: simon <simon@reflex.dev>
Just trying to keep the list short in general. You're right, it's a rather small package, but it still needs to be maintained, updated, license reviewed etc. And it could (for some stupid reason) introduce other dependencies in the future. |
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.