[ENG-3970] When normal pickle fails, try dill #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If dill is not installed, suggest that the user `pip install` it. Fix #4147
When the pickling throws a warning and dill is not installed, include the original pickle error. Add a test case for an object that even dill cannot pickle to ensure error path is hit as expected.
|
Since we are adding dill to pyproject, is there any way that dill wouldn't be installed? |
it's a dev dependency, so it only gets installed when you do |
adhami3310
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dill is not installed, suggest that the user
pip installit.Fix #4147