bump nextJS to v15 #4630
bump nextJS to v15 #4630
Conversation
|
for reviewers, the CI barely runs any macos tests, so it would be great if you can verify this works on your macos machine on reflex-web and other repos of similar size |
To add to this, I ran reflex-web locally with |
|
Testing this branch with the sandbox to see if it improves anything |
| def _compile_package_json(): | ||
| return templates.PACKAGE_JSON.render( | ||
| scripts={ | ||
| "dev": constants.PackageJson.Commands.DEV, | ||
| "dev": constants.PackageJson.Commands.DEV + _turbopack_flag(), |
There was a problem hiding this comment.
one thing i'm hesitant about here is setting/resetting the environment variable is not sufficient to rewrite the package.json, that only happens during init
There was a problem hiding this comment.
i have looked into it, there's no way to do it with config files, so package.json is the only way (unless you want to make package.json read from environment as well, but that seems cursed)
There was a problem hiding this comment.
I don't think it's unreasonable to expect users to re-init when changing how they want to run the frontend dev server, because it's not a flag you'll change frequently.
There was a problem hiding this comment.
@masenf do we have alternatives for this or shall we merge this as is?
The only thing possible to do here is to log last value of this flag and if it changes we regenerate package.json
No description provided.