-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove token check in reflex deploy #4640
Conversation
This logic has been moved upstream to reflex-hosting-cli
Going to mark this as draft until the PR for the hosting-cli is merged. Also maybe we want the |
The requirements for that is already bound ( |
Next version won't work with <=0.1.32, so we need to update the lower bound anyway. |
if the lower bound isn't raised, then upgrades of reflex won't install the new reflex-hosting-cli that said, it's kind of a wash anyway because we have a secondary runtime check for latest version of hosting-cli and tell people to upgrade manually then |
In that case what's the best option here? Allow reflex upgrade to handle upgrading the CLI or leave it to users to do that? The former seems plausible but I'm wondering if there are any repercussions that would make us settle for the latter |
i think it's better to bump the lower bound if this PR depends on things in a later version of |
This logic has been moved upstream to reflex-hosting-cli (via https://github.com/reflex-dev/reflex-hosting-cli/pull/102)