Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include dynamic imports for custom components #4725

Conversation

adhami3310
Copy link
Member

No description provided.

Copy link

linear bot commented Jan 31, 2025

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #4725 will not alter performance

Comparing khaleel/eng-4538-nossrcomponent-doesnt-import-properly-in-rxmemo (d8a6ca8) with main (6231f82)

Summary

✅ 1 untouched benchmarks

@adhami3310 adhami3310 linked an issue Jan 31, 2025 that may be closed by this pull request
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change

@adhami3310 adhami3310 merged commit 80a26b4 into main Feb 1, 2025
39 checks passed
@adhami3310 adhami3310 deleted the khaleel/eng-4538-nossrcomponent-doesnt-import-properly-in-rxmemo branch February 1, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoSSRComponent doesn't import properly in @rx.memo
2 participants