-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove base_state from event types #4740
Conversation
CodSpeed Performance ReportMerging #4740 will not alter performanceComparing Summary
|
(technically a breaking change, but a very easy one to abide by, simply removing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adhami3310 do you think we should bring this for 0.7.0? i haven't updated my third party components yet, but some of them would need some tweaks to work with this change. Probably better to introduce the breakage at once here, or do you think there might be other implications if we bring this in?
I saw bring it, because it's easier for people to catch it in a big update. But I don't feel strongly about it. It should be a harmless update as it only touches typing. |
* remove base_state from event types * pyi that guy * unpack is new * woops * use type alias type to remove ambiguity of where types go * use same thing with LAMBDA_OR_STATE * do it for event type
No description provided.