Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove base_state from event types #4740

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Conversation

adhami3310
Copy link
Member

No description provided.

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #4740 will not alter performance

Comparing remove-base_state-from-event-types (ebc05ef) with main (c3ac051)

Summary

✅ 1 untouched benchmarks

@adhami3310
Copy link
Member Author

(technically a breaking change, but a very easy one to abide by, simply removing, BASE_STATE and the extra brackets work, also: EventType[[], BASE_STATE] bcomes EventType[()])

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhami3310 do you think we should bring this for 0.7.0? i haven't updated my third party components yet, but some of them would need some tweaks to work with this change. Probably better to introduce the breakage at once here, or do you think there might be other implications if we bring this in?

@adhami3310
Copy link
Member Author

Probably better to introduce the breakage at once here, or do you think there might be other implications if we bring this in?

I saw bring it, because it's easier for people to catch it in a big update. But I don't feel strongly about it.

It should be a harmless update as it only touches typing.

@masenf masenf merged commit 19f4074 into main Feb 5, 2025
39 checks passed
@masenf masenf deleted the remove-base_state-from-event-types branch February 5, 2025 20:09
masenf pushed a commit that referenced this pull request Feb 5, 2025
* remove base_state from event types

* pyi that guy

* unpack is new

* woops

* use type alias type to remove ambiguity of where types go

* use same thing with LAMBDA_OR_STATE

* do it for event type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants