Copy/update assets on compile #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy missing and newer files from src to dest
Log debug messages with timing for different processes.
If the assets change between hot reload, then update them before reloading (in case a CSS file was added or something).
CodSpeed Performance ReportMerging #4765 will not alter performanceComparing Summary
|
Lendemor
previously approved these changes
Feb 6, 2025
Lendemor
approved these changes
Feb 6, 2025
masenf
added a commit
that referenced
this pull request
Feb 8, 2025
* Add path_ops.update_directory_tree: Copy missing and newer files from src to dest * add console.timing context Log debug messages with timing for different processes. * Update assets tree as app._compile step. If the assets change between hot reload, then update them before reloading (in case a CSS file was added or something). * Add timing for other app._compile events * Only copy assets if assets exist * Fix docstring for update_directory_tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow updated assets to be copied into
.web/publicduring_compile, so they can be used after hot reloading.Particularly applies to CSS files passed to
rx.App(stylesheets=[...]), which will fail SSG if the file is not found in.web/public.Added some debug timing output for various parts of the compile.