Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reuse existing PreSharedKeyExtension bug (#248) #251

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: Reuse existing PreSharedKeyExtension bug (#248) #251

merged 1 commit into from
Oct 10, 2023

Conversation

VeNoMouS
Copy link
Contributor

@VeNoMouS VeNoMouS commented Oct 9, 2023

No description provided.

@gaukas gaukas linked an issue Oct 9, 2023 that may be closed by this pull request
[BUG] (Fake|Utls)PreSharedKeyExtension #248
Closed
@gaukas gaukas self-requested a review October 9, 2023 23:35
gaukas
gaukas approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@gaukas gaukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Have you tested and are these everything needed to get the bug fixed? Please double check to make sure the examples for session resumption works.

@VeNoMouS
Copy link
Contributor Author

VeNoMouS commented Oct 9, 2023

Looks good to me!

Have you tested and are these everything needed to get the bug fixed? Please double check to make sure the examples for session resumption works.

Was working in my dev, but let me double check from a clean pull, so all my dev debugging etc from the other week is gone

@VeNoMouS
Copy link
Contributor Author

VeNoMouS commented Oct 10, 2023 •
edited
Loading

All appears to be working as should, raw bytes (with and without PSK) && tls-resumption example

@gaukas
Copy link
Contributor

gaukas commented Oct 10, 2023

Thanks!

@gaukas gaukas merged commit 428ca2c into refraction-networking:master Oct 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaukas gaukas gaukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] (Fake|Utls)PreSharedKeyExtension
2 participants
@VeNoMouS @gaukas