fix: generate ClientHelloSpec only once #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaukas
approved these changes
Jul 19, 2024
Co-authored-by: Gaukas Wang <i@gauk.as> Signed-off-by: adotkhan <61702862+adotkhan@users.noreply.github.com>
|
Thank you for the review, change applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #301 where calling
BuildHanshakeStateWithoutSessionwith a random profile, generates a newCilentHelloSpecon each call.This PR assume that
UConn.ClientHelloIDis read-only and that it's value should not be modified, which is my understanding of uTLS currently operates. If this assumption is false, another workaround needs to be found.A review of this is very much appreciated.