Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extMasterSecret mismatch with extended_master_secret extension #307

Merged
merged 1 commit into from
Jul 20, 2024
Merged

fix: extMasterSecret mismatch with extended_master_secret extension #307

merged 1 commit into from
Jul 20, 2024

Conversation

adotkhan
Copy link
Contributor

Fixes an issue where clientHelloMsg.extendedMasterSecret/PubClientHelloMsg.Ems is always true, even if the extended_master_secret extension is not set in the Client Hello (e.g. from a random TLS profile).

gaukas
gaukas approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@gaukas gaukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This change looks good as it should be the responsibility of (*ExtendedMasterSecretExtension).writeToUConn(uc *UConn) to set this field.

@gaukas gaukas merged commit 23de245 into refraction-networking:master Jul 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaukas gaukas gaukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adotkhan @gaukas