Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix definition of default values for sched_options parameters #2885

Merged
merged 2 commits into from
May 26, 2023

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented May 24, 2023

Fixes #2879.

@vkarak vkarak added this to the ReFrame 4.3 milestone May 24, 2023
@vkarak vkarak self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7a811b3) 86.95% compared to head (7a740bc) 86.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2885   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          60       60           
  Lines       11546    11546           
=======================================
  Hits        10040    10040           
  Misses       1506     1506           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 8f86abc into reframe-hpc:master May 26, 2023
@vkarak vkarak deleted the bugfix/default-sched-options branch May 26, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TypeError: can only join an iterable is if resubmit_on_errors is not set
2 participants