Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Improve naming of automatically generated tests #3265

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Sep 21, 2024

The name test attribute is not anymore a full alias of display_name. It hides all special parameters starting with $ that are inserted by the automatic test generation options, such as --repeat, --distribute etc.

Also the test name of the parameterized test with --distribute does not contain any more the partition name, but instead the partition has become a special test parameter.

Finally, all the special parameters are converted to non-loggable.

The motivation behind these changes is that previously both the special parameters and the different name of the "distributed" tests were causing confusion with logging (e.g., different log files, different headers etc.) and were preventing results comparisons with the new --performance-compare option.

@vkarak vkarak added prio: normal enhancement logging reporting Issues related to reporting and processing the test results labels Sep 21, 2024
@vkarak vkarak added this to the ReFrame 4.7 milestone Sep 21, 2024
@vkarak vkarak requested review from ekouts and victorusu September 21, 2024 20:26
@vkarak vkarak self-assigned this Sep 21, 2024
@vkarak vkarak requested a review from teojgo September 23, 2024 08:12
@vkarak vkarak merged commit 48448aa into reframe-hpc:develop Sep 23, 2024
22 checks passed
@vkarak vkarak deleted the enhancement/hide-special-params branch September 23, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement logging prio: normal reporting Issues related to reporting and processing the test results
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants