-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Allow users define custom log handlers and attach them to the framework #3274
Conversation
Hello @dmargala, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2024-10-18 08:09:27 UTC |
ca1ca76
to
66e7a4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have some suggestions on how to make this idea more in sync with the similar idea of custom launchers and schedulers.
We should also add a small documentation section about it in the "how to".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just some style nitpicking.
Thanks. I applied suggestions and also fixed indent spacing in the examples (the spacing in the code blocks had inherited the 3-space indents, I changed it to 4-spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds support for defining a custom log handler that can be specified in the reframe configuration file.
For example, adding a plugin log handler would look something like the following:
There is some prior art in the reframe code base for a similar capability for custom launchers (see extending-the-framework section of the docs). There may be some other ways to implement this by extending the existing Stream or File log handlers to accept custom stream or file objects.
closes #3270