Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] New configuration parameter for specifying commands to install reframe remotely for topology detection #3281

Merged
merged 16 commits into from
Oct 29, 2024

Conversation

Blanca-Fuentes
Copy link
Contributor

@Blanca-Fuentes Blanca-Fuentes commented Oct 7, 2024

This PR adds the option of specifying custom commands to install reframe in a remote partition for the topology auto-detection.

Previously, a clone of reframe was created running bootstrap or pip in order to launch reframe with auto-detect option.
Now, a list of custom commands can be specified to install reframe through general:remote_install to avoid creating a reframe clone with pip or running .\bootstrap.sh.

The reframe --detect-host-topology=topo.json is run after the commands for the remote reframe installation.

Closes #2292.
Closes #2690.
Closes #2979 .

@pep8speaks
Copy link

pep8speaks commented Oct 7, 2024

Hello @Blanca-Fuentes, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-10-29 16:58:01 UTC

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this is a very good start. It would be good to have some unittests that check the basic functionality f the feature.
Some things that maybe we still need to discuss:

  • Should we copy the reframe directory in the custom command case? I think not, as long as we don't have a use case for it.
  • Do we give the option to the user to add commands pre/post in the current scripts (bootstrap/pip)?

docs/config_reference.rst Outdated Show resolved Hide resolved
reframe/frontend/autodetect.py Outdated Show resolved Hide resolved
docs/manpage.rst Outdated Show resolved Hide resolved
@Blanca-Fuentes Blanca-Fuentes requested a review from ekouts October 10, 2024 14:04
reframe/schemas/config.json Outdated Show resolved Hide resolved
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I have a few last comments

@vkarak vkarak added this to the ReFrame 4.7 milestone Oct 17, 2024
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of allowing users to specify the exact commands to run, but I would rather restrict that to the installation commands only. The reframe --detect-host-topology=topo.json should be added always by the framework.

As a result we should rather call the configuration variable as remote_install.

reframe/frontend/cli.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
@Blanca-Fuentes Blanca-Fuentes marked this pull request as ready for review October 22, 2024 12:10
reframe/frontend/autodetect.py Outdated Show resolved Hide resolved
reframe/frontend/autodetect.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
unittests/test_autodetect.py Outdated Show resolved Hide resolved
docs/config_reference.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @Blanca-Fuentes!

@vkarak vkarak changed the title [feat] Add custom commands for topology detection in remote partition [feat] New configuration parameter for specifying commands to install reframe remotely for topology detection Oct 29, 2024
@vkarak vkarak merged commit 9fe4e9f into reframe-hpc:develop Oct 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants