Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Report the undefined parameters if an instantiation of an abstract test or fixture is attempted #3293

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

Blanca-Fuentes
Copy link
Contributor

This PR is to improve the error reporting when skipping tests or reporting ReframeSyntaxErrors.

  • Tests skipped because of undefined parameters now print information regarding the undefined parameters.

Closes #3254

@vkarak vkarak requested review from vkarak and ekouts October 29, 2024 23:49
@vkarak vkarak added this to the ReFrame 4.7 milestone Nov 7, 2024
@vkarak vkarak marked this pull request as ready for review November 7, 2024 16:12
reframe/core/decorators.py Outdated Show resolved Hide resolved
reframe/core/decorators.py Outdated Show resolved Hide resolved
reframe/core/decorators.py Outdated Show resolved Hide resolved
unittests/test_fixtures.py Outdated Show resolved Hide resolved
unittests/test_parameters.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR with my suggestions. Lgtm now, thanks!

@vkarak vkarak changed the title [enhancement] Improve error reporting [enhancement] Report the undefined parameters if an instantiation of an abstract test or fixture is attempted Nov 12, 2024
@vkarak vkarak merged commit ae27651 into reframe-hpc:develop Nov 12, 2024
37 of 38 checks passed
ekouts added a commit to ekouts/reframe that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ReFrame detects the test has undefined parameters, but doesn't say which ones
2 participants