Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Warn instead of failing when a filter expression is invalid for test #3310

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 7, 2024

Instead of failing the whole filtering process and issuing a hard error, we now issue a warning and the test is skipped. Example output:

WARNING: error while evaluating expression `num_nodes > 1` for test case `TestX @generic:default+builtin`: name 'num_nodes' is not defined

@vkarak vkarak added this to the ReFrame 4.7 milestone Nov 7, 2024
@vkarak vkarak requested review from ekouts and teojgo November 7, 2024 17:17
@vkarak vkarak self-assigned this Nov 7, 2024
@vkarak vkarak enabled auto-merge November 12, 2024 09:41
@vkarak vkarak merged commit 37c3e45 into reframe-hpc:develop Nov 12, 2024
38 checks passed
@vkarak vkarak deleted the bugfix/warn-on-filter-expr-errors branch November 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants