Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Allow partition/environment extras to be used also as feature constraints in valid_systems and valid_prog_environs #3316

Merged

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 12, 2024

We do this already for partition resources but I think it makes sense to do it for extras as sometimes a test cares that an extra is defined so as to take its value rather than constrain the test to a specific value, such as %key=val.

@pep8speaks
Copy link

pep8speaks commented Nov 12, 2024

Hello @vkarak, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-11-13 09:01:27 UTC

@vkarak vkarak force-pushed the feat/include-extras-as-feature-constraints branch from df48da0 to 48cb7aa Compare November 12, 2024 16:32
@vkarak vkarak enabled auto-merge November 13, 2024 09:01
@vkarak vkarak merged commit 7d4a7cb into reframe-hpc:develop Nov 13, 2024
38 checks passed
@vkarak vkarak deleted the feat/include-extras-as-feature-constraints branch November 13, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants