Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Prefix special (generated) parameters with . instead of $ #3330

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 29, 2024

The problem with $ is two-fold: it has a special meaning both for shells and for the regex pattern, so it makes it tricky to select a generated test's name with -n.

@vkarak vkarak added this to the ReFrame 4.8 milestone Nov 29, 2024
@vkarak vkarak self-assigned this Nov 29, 2024
teojgo
teojgo previously requested changes Dec 2, 2024
docs/manpage.rst Outdated Show resolved Hide resolved
Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak enabled auto-merge December 6, 2024 09:34
@vkarak vkarak dismissed teojgo’s stale review December 6, 2024 09:51

Suggested changes have been applied.

@vkarak vkarak merged commit 925be11 into reframe-hpc:master Dec 6, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants