Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix relative imports in deeply nested tests #3337

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Dec 2, 2024

This is practically a follow up of #3110 by fixing relative imports of deeply nested tests. Currently, given the following structure:

unittests/resources/checks_unlisted/testlib/
├── __init__.py
├── nested
│   ├── __init__.py
│   └── dummy.py
├── simple.py
└── utility
    └── __init__.py

the following import in nested/dummy.py will crash:

from ..utility import dummy_fixture

@vkarak vkarak added this to the ReFrame 4.8 milestone Dec 2, 2024
@vkarak vkarak requested review from ekouts and teojgo December 2, 2024 16:47
@vkarak vkarak self-assigned this Dec 2, 2024
@vkarak vkarak force-pushed the bugfix/testlib-nested-imports branch from 670ac2f to a186646 Compare December 2, 2024 17:18
@vkarak vkarak merged commit 676aade into reframe-hpc:master Dec 3, 2024
38 checks passed
@vkarak vkarak deleted the bugfix/testlib-nested-imports branch December 3, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants