Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AUROC Bug and allow custom Example Selectors #531

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Fix AUROC Bug and allow custom Example Selectors #531

merged 1 commit into from
Aug 12, 2023

Conversation

rajasbansal
Copy link
Contributor

  • Allow passing custom example selectors which extend the BaseExampleSelector interface
  • Fix AUROC when only class is present

@rajasbansal rajasbansal requested review from nihit and Abhinav-Naikawadi and removed request for nihit August 11, 2023 23:53
Abhinav-Naikawadi
Abhinav-Naikawadi reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@Abhinav-Naikawadi Abhinav-Naikawadi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the docs/examples are accidental right?

@rajasbansal rajasbansal force-pushed the integration branch 2 times, most recently from ee5dcc5 to 1d85940 Compare August 12, 2023 00:04
@rajasbansal
Copy link
Contributor Author

updated with correct changes

@Abhinav-Naikawadi Abhinav-Naikawadi merged commit a80a0de into main Aug 12, 2023
2 checks passed
@Abhinav-Naikawadi Abhinav-Naikawadi deleted the integration branch August 12, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinav-Naikawadi Abhinav-Naikawadi Abhinav-Naikawadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajasbansal @Abhinav-Naikawadi