-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning for the deprecated test_suit
#74
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -392,6 +392,16 @@ def message(self): | |
return "You should have three or more owners of the project on PyPI." | ||
|
||
|
||
class TestSuitDeprecation(BaseTest): | ||
weight = 50 | ||
|
||
def test(self, data): | ||
return "test_suite" not in data | ||
|
||
def message(self): | ||
return "The `setup.py test` command and accompanying `test_suit` field has been deprecated." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure why this typo is everywhere, but the term and corresponding option is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. facepalm Edit: phew I only made that mistake there. So I won't fix it, as the test is pointless in the 4x branch anyway. :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. phew I only made that mistake there. It gets to stay, as the test in pointless in the 4x branch... |
||
|
||
|
||
ALL_TESTS = [ | ||
Name(), | ||
Version(), | ||
|
@@ -411,6 +421,7 @@ def message(self): | |
ValidREST(), | ||
BusFactor(), | ||
DevStatusClassifier(), | ||
TestSuitDeprecation(), | ||
] | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,5 +32,4 @@ | |
tests_require=["six"], | ||
setup_requires=["setuptools"], | ||
zip_safe=True, | ||
test_suite="complete", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this check doesn't actually work, since as mentioned on #72 , this is a Setuptools-specific option (under the
[options]
section insetup.cfg
, or the[tool.setuptools]
table inpyproject.toml
), not anything in the standardized core metadata like everything else you check here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, right, it only works when the metadata is fetched by patching setuptools. So it's useful in Pyroma 3 (which this was) but for Pyroma 4 it's pointless, true. So I can already remove it again. :-)