chore: add duplicate issuer validation (#1001)

regen-network · Apr 8, 2022 · 21d4003 · 21d4003
1 parent 987d33b
commit 21d4003
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/x/ecocredit/core/msg_create_class.go b/x/ecocredit/core/msg_create_class.go
@@ -39,11 +39,18 @@ func (m *MsgCreateClass) ValidateBasic() error {
 	if len(m.CreditTypeAbbrev) == 0 {
 		return sdkerrors.ErrInvalidRequest.Wrap("must specify a credit type abbreviation")
 	}
+
+	duplicateMap := make(map[string]bool)
 	for _, issuer := range m.Issuers {
 
 		if _, err := sdk.AccAddressFromBech32(issuer); err != nil {
 			return sdkerrors.ErrInvalidRequest.Wrap(err.Error())
 		}
+
+		if _, ok := duplicateMap[issuer]; ok {
+			return sdkerrors.ErrInvalidRequest.Wrapf("duplicate issuer %s", issuer)
+		}
+		duplicateMap[issuer] = true
 	}
 
 	if m.Fee != nil {

diff --git a/x/ecocredit/core/msg_create_class_test.go b/x/ecocredit/core/msg_create_class_test.go
@@ -113,6 +113,16 @@ func TestMsgCreateClass(t *testing.T) {
 			},
 			expErr: true,
 		},
+		"invalid duplicate issuer": {
+			src: MsgCreateClass{
+				Admin:            addr1.String(),
+				Issuers:          []string{addr1.String(), addr2.String(), addr1.String()},
+				CreditTypeAbbrev: "C",
+				Metadata:         "hello",
+				Fee:              validFee,
+			},
+			expErr: true,
+		},
 	}
 
 	for msg, test := range tests {