Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event and event value checks to unit tests #1237

Closed
8 tasks
Tracked by #972
ryanchristo opened this issue Jul 5, 2022 · 0 comments · Fixed by #1414
Closed
8 tasks
Tracked by #972

Add event and event value checks to unit tests #1237

ryanchristo opened this issue Jul 5, 2022 · 0 comments · Fixed by #1414
Assignees

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Jul 5, 2022

Summary

We currently have some values that are specifically passed to events and not stored in state (e.g. retirement jurisdiction, cancel reason, bridge note, etc.). It would be nice to test expected events are properly emitted and include expected values.

Problem Definition

We currently have values passed to events and we are not testing if they are properly set.

Proposal

Add checks to make sure all expected events are emitted and each event includes expected values.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants