Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(x/ecocredit): add tests for basket events #1408

Merged
merged 7 commits into from
Aug 24, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Aug 24, 2022

Description

  • adds event checks to basket submodule

ref: #1237


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -1,4 +1,4 @@
package basket_test
package basket
Copy link
Contributor Author

@technicallyty technicallyty Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to set the module address within some of the tests, so had to switch the test package to access the unexported keeper fields.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@dfec263). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage        ?   75.32%           
=======================================
  Files           ?      223           
  Lines           ?    20829           
  Branches        ?        0           
=======================================
  Hits            ?    15689           
  Misses          ?     4185           
  Partials        ?      955           
Impacted Files Coverage Δ
types/testutil/events.go 82.35% <100.00%> (ø)

@technicallyty technicallyty marked this pull request as ready for review August 24, 2022 22:16
@technicallyty technicallyty requested a review from a team August 24, 2022 22:16
@ryanchristo ryanchristo changed the title test(x/ecocredit/basket): basket event checks test(x/ecocredit): basket event checks Aug 24, 2022
@ryanchristo
Copy link
Member

Updated the title. At the moment, we are using scope to refer to the go module. We can update the contributing guidelines if you think this should be different although x/ecocredit/basket is a bit misleading here because x/ecocredit/server/basket is the package that is being updated. I think we should stick with the go module but open to discuss.

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanchristo ryanchristo changed the title test(x/ecocredit): basket event checks test(x/ecocredit): add tests for basket events Aug 24, 2022
@ryanchristo ryanchristo merged commit d146ffd into main Aug 24, 2022
@ryanchristo ryanchristo deleted the ty/1237-basket_event_checks branch August 24, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants