-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(x/ecocredit): add tests for basket events #1408
Conversation
@@ -1,4 +1,4 @@ | |||
package basket_test | |||
package basket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed to set the module address within some of the tests, so had to switch the test package to access the unexported keeper fields.
Codecov Report
@@ Coverage Diff @@
## main #1408 +/- ##
=======================================
Coverage ? 75.32%
=======================================
Files ? 223
Lines ? 20829
Branches ? 0
=======================================
Hits ? 15689
Misses ? 4185
Partials ? 955
|
Updated the title. At the moment, we are using scope to refer to the go module. We can update the contributing guidelines if you think this should be different although |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
ref: #1237
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change