-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/ecocredit): update to single class fee param #1466
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1466 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 243 243
Lines 18628 18624 -4
=======================================
- Hits 14573 14571 -2
+ Misses 3204 3202 -2
Partials 851 851
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Manual Tests: https://hackmd.io/8G5uGrUVS1yI3rxVCadmyQ. Everything works as expected. The only slightly odd behavior is that fee is a required argument in the |
Description
Closes: #1359
This pull request updates the new class fee ORM param to a single class fee. When the class fee is not set, no class fee is required. The proto breaking changes are only breaking changes to the current revision.
Manual Tests: #1466 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change