Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): remove duplicate pagination nil check #1527

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Oct 6, 2022

Description

Ref: #1456

Removes duplicate pagination nil check for AllBalances query method.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 requested a review from a team October 6, 2022 10:22
@aleem1314 aleem1314 mentioned this pull request Oct 6, 2022
40 tasks
@@ -15,9 +14,6 @@ import (
// AllBalances queries all credit balances from state with optional pagination.
// NOTE: If no pagination is given in the request, responses will be limited by the Cosmos SDK's default limit (100).
func (k Keeper) AllBalances(ctx context.Context, req *types.QueryAllBalancesRequest) (*types.QueryAllBalancesResponse, error) {
if req.Pagination == nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate check. GogoPageReqToPulsarPageReq handles nil check.

@ryanchristo ryanchristo changed the title chore(ecocredit): core query methods audit updates refactor(x/ecocredit): remove duplicate pagination nil check Oct 18, 2022
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Updated title to be more descriptive. Also note chore should only be used when not updating production code.

@ryanchristo ryanchristo merged commit 8bafe87 into main Oct 18, 2022
@ryanchristo ryanchristo deleted the aleem/core-queries-audit branch October 18, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants