Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): remove deprecated params keeper #1543

Merged
merged 6 commits into from
Oct 19, 2022

Conversation

aleem1314
Copy link
Contributor

Description

Ref: #1456


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #1543 (796e9b2) into main (a128c39) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1543      +/-   ##
==========================================
- Coverage   78.65%   78.64%   -0.01%     
==========================================
  Files         251      251              
  Lines       18854    18851       -3     
==========================================
- Hits        14829    14826       -3     
  Misses       3161     3161              
  Partials      864      864              
Impacted Files Coverage Δ
x/ecocredit/basket/keeper/keeper.go 100.00% <ø> (ø)
x/ecocredit/marketplace/keeper/keeper.go 100.00% <100.00%> (ø)
x/ecocredit/module/module.go 49.39% <100.00%> (ø)
x/ecocredit/server/server.go 60.97% <100.00%> (-0.93%) ⬇️

@aleem1314 aleem1314 mentioned this pull request Oct 12, 2022
40 tasks
@aleem1314 aleem1314 marked this pull request as ready for review October 12, 2022 14:48
@aleem1314 aleem1314 requested a review from a team October 12, 2022 14:48
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@technicallyty
Copy link
Contributor

not sure why code cov complaining 🤔

@ryanchristo ryanchristo changed the title feat(ecocredit): state machine audit updates refactor(x/ecocredit): remove deprecated params keeper Oct 18, 2022
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ryanchristo
Copy link
Member

Changelog entry? 🙏

@ryanchristo ryanchristo merged commit 98e6571 into main Oct 19, 2022
@ryanchristo ryanchristo deleted the aleem/1456-base-state-machine branch October 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants